Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LoginService login format #22

Closed
wants to merge 2 commits into from
Closed

Conversation

Yputi
Copy link

@Yputi Yputi commented Jan 20, 2024

Updated the !login command to split on ", " to address the issue of players being unable to login having usernames with spaces in it.

Updated the !login command to split on ", " to address the issue of players being unable to login having usernames with spaces in it.
Copy link
Contributor

@pauliusdotpro pauliusdotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/runner/work/discord-bot/discord-bot/DiscordBot.App/Services/LoginService.cs(61,37): error CS1012: Too many characters in character literal [/home/runner/work/discord-bot/discord-bot/DiscordBot.App/DiscordBot.App.csproj]

Adjusted string splitting logic to correctly handle usernames and passwords with spaces. 
Updated the Split method to use double quotes to change from splitting on single char array to string array.
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Yputi
Copy link
Author

Yputi commented Jan 20, 2024

/home/runner/work/discord-bot/discord-bot/DiscordBot.App/Services/LoginService.cs(61,37): error CS1012: Too many characters in character literal [/home/runner/work/discord-bot/discord-bot/DiscordBot.App/DiscordBot.App.csproj]

I've updated this line now in regards to that error

@Yputi Yputi requested a review from pauliusdotpro January 20, 2024 14:16
@Yputi Yputi closed this Jan 20, 2024
@Yputi
Copy link
Author

Yputi commented Jan 20, 2024

Closed as this fix is no longer relevant due to slash-commands being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants